Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-4095): hard to use findOne with filter #3176

Closed
wants to merge 1 commit into from

Conversation

staeke
Copy link

@staeke staeke commented Mar 17, 2022

https://www.mongodb.com/community/forums/t/mongodb-4-1-4-with-typescript-findone-syntax-error-type-void-is-not-assignable-to-type-dbuser-undefined-ts-2322/131533

Description

Fix of https://jira.mongodb.org/browse/NODE-4095

What is changing?

Reorders single parameter overloads of findOne to pick the Filter one in generic consumer code

Is there new documentation needed for these changes?

no

What is the motivation for this change?

The JIRA issue (and community ticket) outlines scenairos that imho should work

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: <type>(NODE-xxxx)<!>: <description>
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@dariakp dariakp added the External Submission PR submitted from outside the team label Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
External Submission PR submitted from outside the team
Projects
None yet
3 participants